feat/one-api
needs attentionviewing older commiteb8eb50 · incrementalpre-PRreviewed 2026-07-29 03:03 UTC0H · 1M · 2L- Purpose
- Establish request-level telemetry on the public API before W3 convergence permanently mixes internal and customer traffic.
- Goal
- Every /v1 request emits one structured log line with route key, credential, org, status, outcome, and duration — enabling baseline read of external-only usage before the dashboard starts consuming the same routes.
- Sub-goals
- W0: P0 security gates (DONE)
- W1: RouteMeta gate (DONE)
- W2: Service keys + validator registry
- W2.5: Instrument public API (THIS COMMIT)
- W3: DUAL convergence public-first
- What
- Added public-v1-telemetry.ts (fire-and-forget emitter), wired into withMetaGate to capture every /v1 request. Marks W2.5 done in one-api.md.
- Why
- One-way-door ordering constraint: instrument before W3 convergence or the baseline question ('which endpoints do customers use?') becomes permanently unanswerable.
- Areas
- apps/platform/src/api/utils+271−12.claude/rules+22−9
- Blast
- ~5 files, +293/-21 lines in this increment. Full branch: ~70 files across domains/core, packages/api, packages/database, apps/platform. Auth, API keys, webhook signing, and now public API telemetry.
Findings · 3
correctness1
method logs 'UNKNOWN' if contract entry lacks method field
apps/platform/src/api/utils/public-v1-meta-gate.ts:104
Contract typed with method?: string — any route without it emits method: 'UNKNOWN' in telemetry. Verify all registered routes carry method.
conventions1
emit closure re-declares AuthContext shape inline — drift risk
apps/platform/src/api/utils/public-v1-meta-gate.ts:124
{ actorType, userId, memberships } declared inline instead of Pick<AuthContext, ...>. TypeScript won't catch a rename of AuthContext.userId. Fix: import and use Pick<AuthContext, ...>.
improvement1
Session actors record memberships[0].orgPublicId — may not reflect active org
apps/platform/src/api/utils/public-v1-meta-gate.ts:134
Multi-org session users always attribute to the first membership. Benign today; revisit when the org-claim GUC lands (Phase-0 prereq).
History · 47 commits
- 82bb5b9blockedincremental5H · 5M · 4L2026-08-12 01:48
- 90aa3d5needs attentionincremental1H · 5M · 3L2026-08-11 19:37
- 29d19a0needs attentionincremental1H · 5M · 9L2026-08-11 17:41
- 9bd8a0cneeds attentionfull0H · 5M · 9L2026-08-11 02:14
- 62ec3f7needs attentionincremental2H · 5M · 6L2026-08-10 22:51
- f93bca9needs attentionincremental2H · 5M · 8L2026-08-10 17:51
- 052db6fneeds attentionincremental1H · 3M · 4L2026-08-09 21:13
- 45699caneeds attentionincremental0H · 7M · 11L2026-08-09 17:44
- b843d8aneeds attentionincremental1H · 7M · 9L2026-08-09 04:05
- e1757b8needs attentionincremental0H · 3M · 6L2026-08-05 02:11
- 7a762faneeds attentionincremental2H · 5M · 5L2026-08-05 01:25
- 3300a60needs attentionincremental2H · 4M · 7L2026-08-04 19:06
- 0c8a7f5needs attentionincremental0H · 4M · 9L2026-08-04 18:15
- 345f42eneeds attentionincremental2H · 6M · 9L2026-08-04 17:28
- 8338a9aneeds attentionincremental5H · 14M · 14L2026-08-04 00:33
- 41be4c3needs attentionincremental0H · 5M · 7L2026-08-03 23:49
- 5ed593dneeds attentionincremental1H · 6M · 6L2026-08-03 21:32
- b333e25needs attentionincremental4H · 9M · 8L2026-08-03 21:00
- 5642cccneeds attentionincremental2H · 3M · 2L2026-08-03 20:17
- 73b0b39needs attentionincremental3H · 10M · 13L2026-07-31 18:29
- b19852eneeds attentionincremental0H · 1M · 5L2026-07-29 05:04
- 3845205needs attentionincremental3H · 6M · 4L2026-07-29 04:47
- eb8eb50needs attentionincremental0H · 1M · 2L2026-07-29 03:03current
- f4720a3needs attentionincremental6H · 8M · 7L2026-07-29 02:54
- f8d341ablockedincremental2H · 2M · 5L2026-07-29 00:00
- a7f1a64needs attentionincremental2H · 8M · 8L2026-07-28 18:41
- 738b60bblockedincremental3H · 6M · 5L2026-07-28 00:46
- 2c248b6needs attentionincremental8H · 12M · 8L2026-07-27 23:23
- 1346cc0needs attentionincremental2H · 8M · 6L2026-07-27 20:15
- 0716018needs attentionincremental2H · 11M · 12L2026-07-27 19:22
- 215cd2dneeds attentionincremental3H · 6M · 5L2026-07-27 17:04
- ec46958needs attentionincremental0H · 3M · 5L2026-07-27 16:51
- de7b337blockedincremental4H · 9M · 14L2026-07-27 06:36
- b1bb9c0needs attentionincremental1H · 2M · 4L2026-07-27 05:09
- 4701d11needs attentionincremental0H · 4M · 3L2026-07-27 04:44
- e1626c4needs attentionincremental3H · 9M · 10L2026-07-27 03:21
- 195f198needs attentionincremental3H · 3M · 3L2026-07-25 01:22
- 42c7358safeincremental0H · 0M · 0L2026-07-22 20:46
- 85b9018needs attentionincremental0H · 1M · 6L2026-07-21 23:51
- a7b2a9aneeds attentionincremental0H · 9M · 12L2026-07-21 18:49
- c2ee0daneeds attentionincremental4H · 7M · 7L2026-07-21 02:17
- e8ffa5eneeds attentionincremental4H · 7M · 5L2026-07-21 01:33
- a2d2a54needs attentionincremental2H · 7M · 3L2026-07-21 00:51
- 576fbd6needs attentionfull1H · 6M · 7L2026-07-21 00:35
- d3465e8needs attentionincremental1H · 7M · 10L2026-07-21 00:23
- dc794a7needs attentionincremental0H · 5M · 5L2026-07-20 23:46
- 9082773needs attentionfull1H · 3M · 3L2026-07-20 23:13