← all branches

feat/one-api

needs attentionviewing older commit
9082773 · fullpre-PRreviewed 2026-07-20 23:13 UTC1H · 3M · 3L · 2I
The branch
Purpose
Clean up .branch/ working-directory litter that was accidentally committed to main on PR #268 (feat/int-base sg12 tools, reference files, intent log), and establish the scope for the One-API program.
Goal
Establish the One-API program: encode the decision and canonical contract grammar as .claude/ rules, and land the U0 groundwork — route-metadata inventory and merged public-id prefix registry.
Sub-goals
  • SG-1: Encode knowledge in .claude/ (one-api.md rule + canonical-form.md rewording)
  • SG-2: Route classification script + inventory (parse 3 routers, emit 245 routes classified)
  • SG-3: Merge PublicIdPrefix registries — shared-kernel is the registry, utility base.ts re-exports
  • SG-4 (stretch): Distill still-load-bearing ADRs (016, 018, 020) into owning rules
  • SG-N: Framework improvements
The changes (whole branch)
What
Provisioning-only commit: 35 .branch/ working-directory files removed (old feat/int-base sg12 data), scope.md updated to feat/one-api plan. No production code changed.
Why
sg12 .branch/ litter was accidentally force-committed to main on PR #268, violating the gitignored .branch/ convention. Cleaned up here before the first implementation SG lands.
Areas
.branch/+44−1253
Blast
35 files, +44/-1253 — all .branch/ working-directory files. Zero production code impact.
git-history-data
➖CI (no PR)· No open PR — pr-checks.yml not triggered➖CodeRabbit· No .coderabbit.yaml in repo

Findings · 9

correctness1

medium

SG-1 deliverables in .branch/reference/ are gitignored — won't be shared with collaborators

.branch/scope.md

Scope cites .branch/reference/canonical-api-scaffolding-audit.html and .branch/reference/one-api-strategy.html as inputs for later SGs, but .branch/ is gitignored. Local-only and invisible to any other developer or reviewer checking out the branch.

security5

medium

Enterprise customer names permanently in git history

.branch/tools/sg12/powerradar-snapshot.json

powerradar-snapshot.json (committed to main in PR #268) contained real enterprise customer names (SANTANDER, MAISON KAYSER, H&M) mapped to internal org/site/device paths. HEAD deletion does not remove from history.

medium

Internal org ID to ULID mapping table in git history

.branch/tools/sg12/org-mapping.json

org-mapping.json mapped legacy numeric org IDs to new ULID public IDs. Combined with snapshot files this allows reconstruction of customer name to internal IDs. Permanently in git history.

low

Security vulnerability details in git-history intent.md

.branch/intent.md

intent.md included R1-R12 vulnerability findings, internal DynamoDB table names, and Enphase prod token handling notes. Still retrievable from git history.

low

.gitignore bypass — .branch/ files can be silently reintroduced

.gitignore

.branch/ is in .gitignore but was bypassed in PR #268 without CI catching it. No structural guardrail prevents recurrence.

info

Production MetricStream public IDs in git-history tool script

.branch/tools/sg12/readpath-sg12.ts

readpath-sg12.ts contained hardcoded production MetricStream public IDs. Not credentials but enumerate specific production data streams. Still in git history.

conventions1

info

CI guard suggestion in Framework Learnings has no tracking SG or Linear issue

.branch/scope.md

Framework Learnings notes 'consider a CI guard against committed .branch/ paths' but no SG task or Linear issue reference exists for it.

improvement2

high

Add CI guard against committed .branch/ files to prevent recurrence

.github/workflows/pr-checks.yml

.branch/ is gitignored yet 35 files from feat/int-base reached main. Add to pr-checks.yml: git ls-files .branch/ | grep -vE '^.branch/(scope.md|intent.md|stashes.log)$' | grep -q . && echo 'ERROR: committed .branch/ litter' && exit 1

low

CI tests step soft-gated — will silently mask unit failures from new packages

.github/workflows/pr-checks.yml

The Run tests step uses continue-on-error: true. As this branch adds packages/shared-kernel and scripts/one-api/, new unit test failures will be swallowed.

History · 47 commits

  1. 82bb5b9blockedincremental5H · 5M · 4L2026-08-12 01:48
  2. 90aa3d5needs attentionincremental1H · 5M · 3L2026-08-11 19:37
  3. 29d19a0needs attentionincremental1H · 5M · 9L2026-08-11 17:41
  4. 9bd8a0cneeds attentionfull0H · 5M · 9L2026-08-11 02:14
  5. 62ec3f7needs attentionincremental2H · 5M · 6L2026-08-10 22:51
  6. f93bca9needs attentionincremental2H · 5M · 8L2026-08-10 17:51
  7. 052db6fneeds attentionincremental1H · 3M · 4L2026-08-09 21:13
  8. 45699caneeds attentionincremental0H · 7M · 11L2026-08-09 17:44
  9. b843d8aneeds attentionincremental1H · 7M · 9L2026-08-09 04:05
  10. e1757b8needs attentionincremental0H · 3M · 6L2026-08-05 02:11
  11. 7a762faneeds attentionincremental2H · 5M · 5L2026-08-05 01:25
  12. 3300a60needs attentionincremental2H · 4M · 7L2026-08-04 19:06
  13. 0c8a7f5needs attentionincremental0H · 4M · 9L2026-08-04 18:15
  14. 345f42eneeds attentionincremental2H · 6M · 9L2026-08-04 17:28
  15. 8338a9aneeds attentionincremental5H · 14M · 14L2026-08-04 00:33
  16. 41be4c3needs attentionincremental0H · 5M · 7L2026-08-03 23:49
  17. 5ed593dneeds attentionincremental1H · 6M · 6L2026-08-03 21:32
  18. b333e25needs attentionincremental4H · 9M · 8L2026-08-03 21:00
  19. 5642cccneeds attentionincremental2H · 3M · 2L2026-08-03 20:17
  20. 73b0b39needs attentionincremental3H · 10M · 13L2026-07-31 18:29
  21. b19852eneeds attentionincremental0H · 1M · 5L2026-07-29 05:04
  22. 3845205needs attentionincremental3H · 6M · 4L2026-07-29 04:47
  23. eb8eb50needs attentionincremental0H · 1M · 2L2026-07-29 03:03
  24. f4720a3needs attentionincremental6H · 8M · 7L2026-07-29 02:54
  25. f8d341ablockedincremental2H · 2M · 5L2026-07-29 00:00
  26. a7f1a64needs attentionincremental2H · 8M · 8L2026-07-28 18:41
  27. 738b60bblockedincremental3H · 6M · 5L2026-07-28 00:46
  28. 2c248b6needs attentionincremental8H · 12M · 8L2026-07-27 23:23
  29. 1346cc0needs attentionincremental2H · 8M · 6L2026-07-27 20:15
  30. 0716018needs attentionincremental2H · 11M · 12L2026-07-27 19:22
  31. 215cd2dneeds attentionincremental3H · 6M · 5L2026-07-27 17:04
  32. ec46958needs attentionincremental0H · 3M · 5L2026-07-27 16:51
  33. de7b337blockedincremental4H · 9M · 14L2026-07-27 06:36
  34. b1bb9c0needs attentionincremental1H · 2M · 4L2026-07-27 05:09
  35. 4701d11needs attentionincremental0H · 4M · 3L2026-07-27 04:44
  36. e1626c4needs attentionincremental3H · 9M · 10L2026-07-27 03:21
  37. 195f198needs attentionincremental3H · 3M · 3L2026-07-25 01:22
  38. 42c7358safeincremental0H · 0M · 0L2026-07-22 20:46
  39. 85b9018needs attentionincremental0H · 1M · 6L2026-07-21 23:51
  40. a7b2a9aneeds attentionincremental0H · 9M · 12L2026-07-21 18:49
  41. c2ee0daneeds attentionincremental4H · 7M · 7L2026-07-21 02:17
  42. e8ffa5eneeds attentionincremental4H · 7M · 5L2026-07-21 01:33
  43. a2d2a54needs attentionincremental2H · 7M · 3L2026-07-21 00:51
  44. 576fbd6needs attentionfull1H · 6M · 7L2026-07-21 00:35
  45. d3465e8needs attentionincremental1H · 7M · 10L2026-07-21 00:23
  46. dc794a7needs attentionincremental0H · 5M · 5L2026-07-20 23:46
  47. 9082773needs attentionfull1H · 3M · 3L2026-07-20 23:13current