← all branches

feat/int-base

safe
f7b9554 · incrementalPR #268reviewed 2026-07-13 20:18 UTC0H · 0M · 0L · 1I
The branch
Purpose
Land every shared seam the 12 device-integration ports depend on — manifests, catalog seeds, ARN-seed registry, CDK path entries, migration scripts — so each per-brand branch only touches its own vendor directories.
Goal
Foundation for migrating all 12 legacy device integrations (mgmt account → this codebase), with per-brand branches stacked on top.
Sub-goals
  • SG-1: 12 integration manifests + registration ✓
  • SG-2: Catalog seed rows (Makes, Integrations, MetricTypes) ✓
  • SG-3: ARN-seed REGISTRY entries + missing-Lambda tolerance ✓
  • SG-4: CDK paths.ts handler entries ✓
  • SG-5: D3 registry-migration script (dry-run first) ✓
  • SG-6: D2 credential-copy script (dry-run first) ✓
  • SG-7: 1M calendar-month granularity end to end ✓
  • SG-8: Canonicalize multi-gran worker contract (docs) ✓
  • SG-9: Fix inert coverage clamp (union-based, 1M-safe) ✓
  • SG-10: Consolidation merge — 12 brand branches into int-base ✓
  • SG-11: Sync latest main + hoymiles seed fix ✓
  • SG-12: Combined validation on full int-base estate ✓
  • SG-13: Review remediation (enphase R1–R5, fronius R6/R12, docs R14) ✓
  • SG-14: Review 4 Loop-C-uncovered brands (victron/abb/sma/solark) ✓
  • Ongoing: doc corrections from Loop C review findings
The changes (whole branch)
What
Single-cell table fix in sma/INFRA_DESIGN.md: 'our transform' column for the 5m row changed from 'Σ W×300/3.6e6' to 'W passthrough'; the integral formula moved to the 'faithful?' cell prefixed as 'consumer integral'.
Why
Loop C flagged the prior cell implied the worker computes the energy integral; in reality the SMA worker passes raw W values and the integral is the consumer's responsibility (site-metrics-seam.md). Fixing the doc prevents a future porter from adding a redundant worker-side transform.
Areas
services/metrics/integrations/sma/INFRA_DESIGN.md+1−1
Blast
1 file, +1/−1; docs-only, no code or test changes.
➖typecheck· docs-only change; no CI checks returned➖coderabbit· no .coderabbit.yaml in repo

Findings · 1

correctness1

info

Doc correction is architecturally accurate

services/metrics/integrations/sma/INFRA_DESIGN.md:73

The old cell showed 'Σ W×300/3.6e6' as the worker transform, implying the worker computed energy. The new 'W passthrough' correctly shows the worker's role (store raw watts); the formula is re-attributed as the 'consumer integral', matching site-metrics-seam.md and the SMA section in integrations/CLAUDE.md ('5m = instantaneous W (passthrough)'). Fix prevents a future porter from adding a worker-side integral that would double-transform the series.

History · 11 commits

  1. f7b9554safeincremental0H · 0M · 0L2026-07-13 20:18current
  2. 9ca23adneeds attentionincremental0H · 3M · 3L2026-07-13 19:17
  3. 595484fneeds attentionincremental1H · 3M · 7L2026-07-13 04:29
  4. 2ed62f4safeincremental0H · 0M · 0L2026-07-13 04:13
  5. 2812f54needs attentionincremental1H · 3M · 10L2026-07-11 00:19
  6. 1794b23needs attentionincremental2H · 2M · 5L2026-07-10 21:59
  7. e5674dcneeds attentionincremental3H · 7M · 6L2026-07-09 19:29
  8. ca45a96needs attentionincremental0H · 3M · 3L2026-07-09 18:56
  9. 5d19484safeincremental0H · 0M · 1L2026-07-08 02:04
  10. dd403feneeds attentionincremental12H · 22M · 12L2026-07-07 20:02
  11. e663ae9needs attentionincremental2H · 7M · 7L2026-07-07 19:02