← all branches

feat/int-base

safeviewing older commit
5d19484 · incrementalPR #268reviewed 2026-07-08 02:04 UTC0H · 0M · 1L · 1I
The branch
Purpose
Land every shared seam the 12 device-integration ports depend on — manifests, catalog seeds, ARN-seed registry entries, CDK path entries, and legacy-registry/credential migration scripts — so each per-brand branch only touches its own vendor directories.
Goal
All 12 IntegrationManifests registered, seed rows consistent, ARN registry populated, CDK paths present, and migration scripts (D2/D3) validated on a preview DB.
Sub-goals
  • SG-1: 12 manifests + registration (done)
  • SG-2: Catalog seed rows — Makes, Integrations, MetricTypes (done)
  • SG-3: ARN-seed REGISTRY entries + missing-Lambda tolerance (done)
  • SG-4: CDK paths.ts handler entries (done)
  • SG-5: D3 registry-migration script — dry-run first (done)
  • SG-6: D2 credential-copy script — dry-run first (done)
  • SG-N: Framework improvements — retire stale manifest co-location guidance (done)
The changes (whole branch)
What
Corrects credential field names for hoymiles (token→api_key) and shelly-cloud (api_key/access_token→user/password) in both manifest files and seed-metrics-catalog, sourced from live-verified production payloads.
Why
SG-1 intent log flagged hoymiles/shelly field names as needing live-prod verification; this commit closes that gap before brand branches wire credential shells.
Areas
packages/integration-manifests+124packages/database+44scripts/metrics+12820infra/cdk/src/lib+1850domains/core/src/secret-configuration+161services/metrics/integrations+385.branch+102160
Blast
~35 files, +1700/−174 lines across manifests, DB seeds, migration scripts, CDK paths, framework docs. Zero production behaviour change — no Lambda workers yet.
solis-credential-fields-unverified
ci/typecheck· No CI data via gh pr checkscoderabbit· No .coderabbit.yaml in repo

Findings · 2

correctness1

info

Solis key_id/key_secret still carry the SG-1 unverified caveat

packages/integration-manifests/src/manifests/solis.ts

This commit resolves Hoymiles; Solis remains unverified per SG-1 intent log. Not a blocker — brand branch will validate before wiring its credential shell.

conventions1

low

Shelly Cloud uses `user` while Growatt uses `username` for the non-secret identifier

packages/integration-manifests/src/manifests/shelly-cloud.ts:38

Growatt (growatt.ts:53) names its non-secret field `username`; Shelly Cloud uses `user`. Both are valid — `user` matches the live prod key — but the inconsistency may surprise a future credential-shell author using Growatt as a template. Low risk: shell reads fields generically via the manifest.

History · 11 commits

  1. f7b9554safeincremental0H · 0M · 0L2026-07-13 20:18
  2. 9ca23adneeds attentionincremental0H · 3M · 3L2026-07-13 19:17
  3. 595484fneeds attentionincremental1H · 3M · 7L2026-07-13 04:29
  4. 2ed62f4safeincremental0H · 0M · 0L2026-07-13 04:13
  5. 2812f54needs attentionincremental1H · 3M · 10L2026-07-11 00:19
  6. 1794b23needs attentionincremental2H · 2M · 5L2026-07-10 21:59
  7. e5674dcneeds attentionincremental3H · 7M · 6L2026-07-09 19:29
  8. ca45a96needs attentionincremental0H · 3M · 3L2026-07-09 18:56
  9. 5d19484safeincremental0H · 0M · 1L2026-07-08 02:04current
  10. dd403feneeds attentionincremental12H · 22M · 12L2026-07-07 20:02
  11. e663ae9needs attentionincremental2H · 7M · 7L2026-07-07 19:02