fix/cfe-silent-ok
safeviewing older commit662c8d1 · fullpre-PRreviewed 2026-07-17 01:01 UTC0H · 0M · 0L · 1IThe branch
- Purpose
- Fix BAT-272: CFE collector reports a failed Mi Espacio registration as a successful collection (silent-ok bug). A transient Mi Espacio failure retries via SFN but then grades 'completed' instead of 'failed'.
- Goal
- A recoverable Mi Espacio failure + 0 periods contributed ⇒ collector throws RecoverableCollectionFailure so the SFN Retry matches; failure + partial data ⇒ run-level RPU_REGISTRATION_FAILED entry so decideFinalizeJob grades partial_success/failed.
- Sub-goals
- SG-1 — Repair recoverable gate + export decideMiEspacioRecoverableAction pure helper; wire at collector.lambda.ts:188 and :334; unit tests
- SG-2 — Pin finalize grading regression tests; document run-level-failure lever in cfe-pipeline.md
- SG-N — Fold learnings back into framework files
The changes (whole branch)
- What
- Branch provisioning only: .branch/scope.md (plan for BAT-272) + .branch/intent.md (cleared from prior branch reuse).
- Why
- Establish branch scope before implementation; no production code changed.
- Areas
- .branch/scope.md+96−119.branch/intent.md+0−200
- Blast
- 2 files, +96/-319 — branch docs only, zero production impact.
provision-only no-code-changes
➖ci· no CI checks on provision-only commit➖coderabbit· no .coderabbit.yaml
Findings · 1
conventions1
info
Branch scope documents a solid plan
.branch/scope.md
Four success criteria, key findings, and a two-SG implementation plan are all present. The scope correctly identifies the three guards as one rule at two altitudes and notes the cache carve-out. No code yet — this finding is just a scope-quality signal.