fix/cfdi-columns
safeviewing older commit74e05c5 · incrementalpre-PRreviewed 2026-08-04 22:43 UTC0H · 0M · 0LThe branch
- Purpose
- Fix CFDI fiscal concept columns — surface CFDI stamp state, correct column rendering, add staged backfill tooling, and resolve a lint regression from the json-type fix.
- Goal
- Stable CFDI column rendering in the bills table with a backfill mechanism for historical fiscal concept data.
- Sub-goals
- SG-1: Surface CFDI stamp state and stop rendering text/json columns as numbers
- SG-2: Scope the CFDI fiscal concept backfill by organization
- SG-3: Add --since chunking to the backfill script
- SG-4: Fix no-fallthrough lint error introduced by the inter-case comment
The changes (whole branch)
- What
- Removes the comment sitting between `case 'text':` and `case 'json':` in the `decideTypeFromUnits` switch — which ESLint's no-fallthrough rule was flagging — and relocates it into the JSDoc block above the function.
- Why
- The comment was placed between two consecutive case labels, which ESLint treats as a statement that breaks the implicit-fallthrough exemption for empty cases. Moving it to the JSDoc silences the lint error without any behavior change.
- Areas
- domains/utility/src/bill-concepts-catalog+121−6packages/database/src+78−0scripts+448−0services/utility/bills/cfe+327−1apps/web/src+709−2
- Blast
- 14 files changed (cumulative branch), +1363/−12 lines across 5 areas; this commit touches 1 file (+3/−2 lines).
➖typecheck· not run in this review pass✅tests· case 'json' branch covered at bill-concepts-catalog.decisions.test.ts line ~45➖coderabbit· no .coderabbit.yaml
Findings · 0
No findings.