feat/discovery

sameNameSite advisory can show stale site name after input is cleared

apps/platform/src/app/[locale]/(dashboard)/bills/_components/InlineContractForm.tsx:196

The sameNameSite effect depends only on [siteOptions] but reads serviceName, customSiteName, useServiceAsSite, siteMode, and submitting from closure. If the user clears the service name field while siteOptions has not re-fetched, the effect does not re-run and sameNameSite stays non-null — the amber advisory remains visible referencing a site that no longer matches the current input. Fix: add the missing closure variables to the dependency array, or capture a ref snapshot of the inputs inside the effect.

SiteModeToggle does not clear sameNameSite — advisory can resurface unexpectedly

apps/platform/src/app/[locale]/(dashboard)/bills/_components/InlineContractForm.tsx:586

When the user clicks the SiteModeToggle directly (not the advisory's 'Usar el sitio existente' button), the toggle sets userChoseModeRef.current = true and setSiteMode(m) but does NOT call setSameNameSite(null). The advisory is hidden while in 'existing' mode. However if the user later switches back to 'new' mode, the effect bails early (userChoseModeRef.current === true) and sameNameSite retains its old value, causing the advisory to reappear with a stale site reference. Fix: add setSameNameSite(null) to the SiteModeToggle onChange handler.

useLookupContract enabled guard uses '>= 11' — dead condition after 12-digit fix

apps/platform/src/app/[locale]/(dashboard)/bills/_components/AddContractDrawer.tsx:182

useLookupContract is called with enabled: debounced.length >= 11. Since shouldLookup only fires at exactly 12 digits, debounced is always '' when digits < 12, so the >= 11 check is never independently reached. The guard should be debounced.length === 12 to match the stated invariant and prevent any future path from triggering a lookup on an 11-digit value.

[role='dialog'] in row click guard is a dead selector

apps/platform/src/app/[locale]/(dashboard)/bills/contratos/_components/ContractsTable.tsx:669

The guard target.closest('button, a, input, [role="checkbox"], [role="dialog"]') includes [role="dialog"]. Radix/shadcn dialogs render in portals outside the table DOM — a click inside a dialog cannot bubble through a <tr>. The selector is harmless today but misleading to maintainers and could cause unintended behavior if dialogs ever render inside table rows.

detailId useState reads window.location.search — SSR/client hydration mismatch

apps/platform/src/app/[locale]/(dashboard)/bills/contratos/page.tsx:130

The lazy initializer guards against SSR with typeof window === 'undefined' but still produces a null (server) vs non-null (client with ?detail=id in URL) mismatch on hydration. The established App Router pattern is useSearchParams() — already used on this page (discoverySearchParams) and SSR-safe by design. Using it for the initial detailId read would eliminate the guard and the mismatch.

No client-side publicId format validation before issuing chapters query

apps/platform/src/app/[locale]/(dashboard)/bills/contratos/page.tsx:131

The ?detail param is passed directly to the API as publicId. The server handles arbitrary strings safely (parameterized queries, returns 404 for unknown IDs). A lightweight format guard (e.g. /^ctr_[0-9A-Z]{26}$/) would fail fast on malformed deep-links and avoid unnecessary API round-trips. Not a security risk given server-side safety.

chapters handler service-role bypass is load-bearing — document the invariant

apps/platform/src/api/handlers/utility-contracts.handler.ts

After confirming org access via RLS-wrapped findOverviewByContractPublicId, subsequent reads use the service-role connection (no RLS). This is correct because utility_contracts/bills carry no org_id. The org gate is the overview lookup. The invariant — subsequent reads must only use IDs returned by the authenticated overview, never client-supplied IDs — is currently enforced by convention only. Adding a typed scope object would make the constraint structurally enforced.

Removed i18n keys monitoredOnly/fullHistory — verified clean

apps/platform/src/messages/en.json

Both keys removed from en.json and es.json. Grep confirms no remaining references in .tsx/.ts files. Clean removal.

PR description references stale migration number '0058' (actual: 0064)

packages/database/drizzle/0064_discovery_state.sql

The migration was renumbered from 0063 to 0064 when main was merged in (per commit message). The PR description still says 'migration 0058'. Cosmetic only — no runtime impact. Update the PR body for audit trail accuracy.

12-digit RPU validation boundary (was 11) has no regression test

apps/platform/src/app/[locale]/(dashboard)/bills/_components/AddContractDrawer.tsx:156

The 11→12 digit boundary fix was a confirmed production bug (11-digit incomplete numbers verified as valid). The LookupState state machine — shouldLookup, debounced, too-short, too-long, showLengthHint — is entirely untested. A unit test covering 11 digits → too-short, 12 digits → triggers lookup, 13 digits → too-long would guard against regression.

ID-vs-name match split in InlineContractForm advisory has no unit test

apps/platform/src/app/[locale]/(dashboard)/bills/_components/InlineContractForm.tsx:195

The three-way branch (ID match → auto-switch; name match → advisory only; no match → clear) guards against the 379-sites mass-merge bug at the UI layer. The backend decision function is well-tested, but the UI advisory path is not. A mismatch here could silently re-introduce the over-merge bug even though the backend is correct.

Drawer deep-link URL state not covered by tests

apps/platform/src/app/[locale]/(dashboard)/bills/contratos/page.tsx:130

openDetail, closeDetail, and the detailId initializer (deep-link from ?detail= on load) are untested. The deep-link init path is the kind of edge case easy to break silently, especially after router changes.

ContractsTable onOpenDetail prop not exercised in existing memo test

apps/platform/src/app/[locale]/(dashboard)/bills/contratos/_components/ContractsTable.tsx

The existing ContractsTable.memo.test.tsx renders without onOpenDetail. No test verifies the row click calls the handler or that rows gracefully no-op without the prop.

chapters handler wiring has no integration test

apps/platform/src/app/api/[...ts-rest]/route.ts:499

The new chapters: listContractChaptersHandler wiring is not covered by an integration smoke test. An auth regression or contract-shape mismatch would go undetected until runtime.