claude/zealous-lovelace-cbc97f

CREATE TEMP TABLE not schema-qualified (asymmetry with qualified references)

packages/database/drizzle/0053_organic_changeling.sql

All references use pg_temp._uco_drift but CREATE TEMP TABLE _uco_drift is unqualified. Not exploitable (PostgreSQL always creates temp tables in pg_temp), but asymmetry is a maintenance hazard.

Redaction regex misses libpq key=value DSN form

.github/workflows/uco-drift-watchdog.yml:69

sed pattern covers postgres(ql):// URIs but not key=value DSNs. add-mask is the primary protection; real risk is very low.

Test teardown deletes from audit table — confirm non-prod guard

domains/utility/src/utility-contract-overview/__tests__/utility-contract-overview.reconcile.integration.test.ts:150

afterAll deletes audit rows via service_role. Verify integration tests cannot target production DB.

ReconcileRow type alias inside function body (should be module-scope)

domains/utility/src/utility-contract-overview/utility-contract-overview.queries.ts

Move ReconcileRow outside runOverviewReconcile to module scope for reuse.

runOverviewReconcile throws instead of returning Result<T, E>

domains/utility/src/utility-contract-overview/utility-contract-overview.queries.ts

FCIS convention requires fallible operations to return Result<T, E>. A missing stored-procedure row is a recoverable infrastructure failure.

Test helper reconcile() shadows shell naming convention

domains/utility/src/utility-contract-overview/__tests__/utility-contract-overview.reconcile.integration.test.ts:63

By FCIS convention, reconcile implies a shell. Rename to runReconcileQuery().

Raw Drizzle delete in afterAll bypasses query layer

domains/utility/src/utility-contract-overview/__tests__/utility-contract-overview.reconcile.integration.test.ts:147

Project convention: all DB operations behind query helpers in queries.ts.

No test coverage for the new throw path in runOverviewReconcile

domains/utility/src/utility-contract-overview/utility-contract-overview.queries.ts:597

The throw new Error guard is untested. Add a unit test with a stubbed db.execute returning empty results.

repairedCount === driftCount assertion fragile under concurrent suites

domains/utility/src/utility-contract-overview/__tests__/utility-contract-overview.reconcile.integration.test.ts:196

reconcile() operates on ALL orgs in DB. Concurrent suites could push total drift past the 2000-pair cap. Use toBeGreaterThanOrEqual(1) instead.

afterAll doesn't guard on undefined contractM/contractU

domains/utility/src/utility-contract-overview/__tests__/utility-contract-overview.reconcile.integration.test.ts:159

If beforeAll fails mid-way, contractM/contractU may be undefined. Guard each cleanup statement.

durationMs ?? 0 makes assertion trivially pass even when null

domains/utility/src/utility-contract-overview/__tests__/utility-contract-overview.reconcile.integration.test.ts:209

Use expect(run!.durationMs).not.toBeNull() + expect(run!.durationMs).toBeGreaterThanOrEqual(0).

Converged run doesn't assert driftCount=0/repairedCount=0 on audit row

domains/utility/src/utility-contract-overview/__tests__/utility-contract-overview.reconcile.integration.test.ts:270

Add expect(run!.driftCount).toBe(0) and expect(run!.repairedCount).toBe(0) to complete the convergence contract.

Module-level mutable cleanup array should be scoped to describe block

domains/utility/src/utility-contract-overview/__tests__/utility-contract-overview.reconcile.integration.test.ts

createdRunIds at module scope is a shared mutation risk.

Array.from(result as Iterable<ReconcileRow>) is unnecessarily indirect

domains/utility/src/utility-contract-overview/utility-contract-overview.queries.ts

Destructuring from result.rows is cleaner than casting to Iterable.

Credential-redaction sed expression duplicated twice in workflow

.github/workflows/uco-drift-watchdog.yml:66

Extract into a reusable shell function or composite step.