claude/priceless-faraday-314fa0
safe070e3e0 · incrementalPR #293reviewed 2026-07-11 04:04 UTC0H · 0M · 1L · 2I- Purpose
- Move SEO enforcement from a GHA CI gate into the code-review panel as a web-only advisory lens
- Goal
- Delete seo-checks.yml; add seo lens to review-panel; update all docs that referenced the old workflow
- Sub-goals
- SG-1: Remove seo-checks.yml + lighthouse-budget.json
- SG-2: Add seo lens to review-panel/SKILL.md
- SG-3: Add seo to config.json review.lenses (self-skips on non-apps/web diffs)
- SG-4: Update doc files removing references to deleted workflow
- SG-5: Polish loop-review SKILL.md SEO cross-check sub-bullets
- What
- Deleted seo-checks.yml + lighthouse-budget.json; added seo lens definition; updated loops-engine config.json; corrected 4 doc files; polished loop-review SKILL.md and scripts/seo-assert.mjs
- Why
- Team decision (Alex): CI gate caused false positives on platform PRs; advisory lens is more appropriate
- Areas
- .claude/rules+15−9.claude/skills+18−3.github/workflows+1−84docs+13−12e2e/web+2−2scripts+6−2
- Blast
- 12 files, +55/−119 across .claude/rules, .claude/skills, .github/workflows, docs, e2e/web, scripts. No production code changed.
Findings · 3
correctness1
Resolution order mentions 'Vercel PR deployment' as distinct step; e2e.yml uses only env-var → template
.claude/skills/review-panel/SKILL.md:28
The new sub-bullet says 'Resolve via env PLAYWRIGHT_WEB_BASE_URL or the Vercel PR deployment before falling back to the template,' implying three sources. e2e.yml (lines 108-109) implements only two: env var → slug-derived template. Inherited from old paragraph — may mislead an implementer.
improvement2
Redundancy: 'different Vercel project' stated in both sub-bullets
.claude/skills/review-panel/SKILL.md:29
The 'Don't confuse the projects' bullet largely restates what the first sub-bullet already implies. Could merge into one.
Workflow file reference adds indirection; inline spec already present
.claude/skills/review-panel/SKILL.md:27
'derived exactly as e2e.yml / preview-provision.yml do it' asks readers to open those files; the inline spec (/ → -, lowercased) is already present in parens.