chore/ph-alerts
needs attentionviewing older commit6d64f0b · fullpre-PRreviewed 2026-07-30 18:12 UTC0H · 2M · 3L · 13IThe branch
- Purpose
- Stop alert fatigue from 4 PostHog alerts that were generating constant noise (~97 days of false pages)
- Goal
- Disable broken alerts cleanly without destroying their definitions, preserving the re-enable path
- Sub-goals
- Disable job_success_rate_low — CFE job events never emitted by Lambda pipeline
- Disable job_failure_spike — CFE job.failed never emitted by Lambda pipeline
- Disable new_subscription — inverted threshold fires on absence, not occurrence
- Disable subscription_churned — inverted threshold fires on absence, not occurrence
The changes (whole branch)
- What
- infra/posthog/alerts.tf: added enabled=false to 4 alert resources with explanatory DISABLED comments
- Why
- 4 alerts were generating false positives: 2 read events the prod Lambda pipeline never emits (only the abandoned Vercel HTTP endpoint did), 2 had inverted threshold logic (lower-bound=1 fires every day with zero events)
- Areas
- infra/posthog+20−0
- Blast
- 1 file, +20/-0. PostHog-only IaC. No application code touched.
➖CI· No open PR — no CI checks available➖CodeRabbit· No .coderabbit.yaml in repo➖terraform-plan· pr-checks.yml runs plan on PR open — not yet triggered (pre-PR branch)
Findings · 7
correctness3
medium
no_invitations_7d and no_bills_exported_7d may share the inverted-logic pattern
infra/posthog/alerts.tf
low
job_failure_spike comment contradicts itself — 'can NEVER fire' vs 'last notified 2026-04-10'
infra/posthog/alerts.tf:86
low
no_events_1h resource name vs display name mismatch
infra/posthog/alerts.tf
conventions2
medium
Dangling reference to non-existent .claude/rules/posthog-annotations.md
infra/posthog/alerts.tf:53
low
No Linear issue linked for re-enable action items
infra/posthog/alerts.tf
improvement2
info
Consider a shared local for the disabled-alert pattern
infra/posthog/alerts.tf
info
Comment verbosity uneven — inverted-logic alerts lack re-enable action pointer
infra/posthog/alerts.tf